Fix testcontainers dependency scope #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testcontainers must have a test scope. Currently, it is a transitive dependency. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
eddumelendez
force-pushed
the
fix-testcontainers-scope
branch
from
fcd7478
to
5e553c6
Compare
eddumelendez
force-pushed
the
fix-testcontainers-scope
branch
from
aca5c06
to
68562d9
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eddumelendez, yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yhmo
pushed a commit
to yhmo/milvus-sdk-java
that referenced
this pull request
Jul 12, 2024
* Fix testcontainers dependency scope Testcontainers must have a test scope. Currently, it is a transitive dependency. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> * Use BOM Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> --------- Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
yhmo
pushed a commit
to yhmo/milvus-sdk-java
that referenced
this pull request
Jul 12, 2024
* Fix testcontainers dependency scope Testcontainers must have a test scope. Currently, it is a transitive dependency. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> * Use BOM Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> --------- Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
|
@eddumelendez |
eddumelendez
added a commit
to eddumelendez/milvus-sdk-java
that referenced
this pull request
Jul 12, 2024
* Fix testcontainers dependency scope Testcontainers must have a test scope. Currently, it is a transitive dependency. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> * Use BOM Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> --------- Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
eddumelendez
added a commit
to eddumelendez/milvus-sdk-java
that referenced
this pull request
Jul 12, 2024
* Fix testcontainers dependency scope Testcontainers must have a test scope. Currently, it is a transitive dependency. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> * Use BOM Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> --------- Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
SwechchhaSinha
pushed a commit
to SwechchhaSinha/milvus-sdk-java
that referenced
this pull request
Jul 16, 2024
* Fix testcontainers dependency scope Testcontainers must have a test scope. Currently, it is a transitive dependency. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> * Use BOM Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> --------- Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> Signed-off-by: Swechchha Sinha <swechchha.sinha@salesforce.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jul 29, 2024
* Fix testcontainers dependency scope (#991) * Fix testcontainers dependency scope Testcontainers must have a test scope. Currently, it is a transitive dependency. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> * Use BOM Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> --------- Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> * Fix import Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> --------- Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Jul 29, 2024
* Fix testcontainers dependency scope (#991) * Fix testcontainers dependency scope Testcontainers must have a test scope. Currently, it is a transitive dependency. Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> * Use BOM Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> --------- Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> * Fix import Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com> --------- Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testcontainers must have a test scope. Currently, it is a transitive dependency.