Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search parameter of annoy has conflict with document #2649

Closed
op-hunter opened this issue Jun 22, 2020 · 0 comments · Fixed by #2667 or #2958
Closed

search parameter of annoy has conflict with document #2649

op-hunter opened this issue Jun 22, 2020 · 0 comments · Fixed by #2667 or #2958
Assignees
@op-hunter @del-zhenwu
Labels
kind/bug Issues or changes related a bug

Comments

@op-hunter
Copy link
Contributor

Describe the bug
As document says, the default search parameter of index annoy is -1 while this value cannot pass parameters validation.

Expected behavior
-1 can be set as default value.
@op-hunter op-hunter self-assigned this Jun 22, 2020
@op-hunter op-hunter mentioned this issue Jun 22, 2020
Merged
JinHai-CN pushed a commit that referenced this issue Jun 23, 2020
@op-hunter
#2649 Remove annoy search parameter validation (#2650)
3b38f7f 
* remove annoy search parameter validation

Signed-off-by: cmli <chengming.li@zilliz.com>

* fix test failed

Signed-off-by: cmli <chengming.li@zilliz.com>

* fix lint error

Signed-off-by: cmli <chengming.li@zilliz.com>

* fix lint error again

Signed-off-by: cmli <chengming.li@zilliz.com>

Co-authored-by: cmli <chengming.li@zilliz.com>
@shengjun1985 shengjun1985 mentioned this issue Jun 24, 2020
Merged
@shengjun1985 shengjun1985 added the kind/bug Issues or changes related a bug label Jun 24, 2020
@op-hunter op-hunter mentioned this issue Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@op-hunter op-hunter

@del-zhenwu del-zhenwu

Labels
kind/bug Issues or changes related a bug
Projects
None yet
Milestone
No milestone
3 participants
@op-hunter @shengjun1985 @del-zhenwu