Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2649 Remove annoy search parameter validation #2650

Merged
merged 5 commits into from
Jun 23, 2020

Conversation

op-hunter
Copy link
Contributor

Signed-off-by: cmli chengming.li@zilliz.com

What type of PR is this?

bug

Need this PR be picked to master branch?

Yes

Which issue(s) this PR fixes:

Fixes #2649

What this PR does / why we need it:

solve the conflict with document

Special notes for your reviewer:
no

Additional documentation (e.g. design docs, usage docs, etc.):

Signed-off-by: cmli <chengming.li@zilliz.com>
cmli added 3 commits June 22, 2020 15:58
Signed-off-by: cmli <chengming.li@zilliz.com>
Signed-off-by: cmli <chengming.li@zilliz.com>
Signed-off-by: cmli <chengming.li@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2020

This pull request is now in conflicts. Could you fix it? 🙏

@sahuang sahuang changed the title remove annoy search parameter validation #2649 Remove annoy search parameter validation Jun 22, 2020
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #2650 into 0.10.1 will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           0.10.1    #2650   +/-   ##
=======================================
  Coverage   91.12%   91.13%           
=======================================
  Files         430      430           
  Lines       26715    26664   -51     
=======================================
- Hits        24345    24300   -45     
+ Misses       2370     2364    -6     
Impacted Files Coverage Δ
core/src/utils/ValidationUtil.cpp 85.76% <0.00%> (ø)
.../src/server/delivery/request/SearchByIDRequest.cpp 71.05% <0.00%> (-1.45%) ⬇️
core/src/server/delivery/request/SearchRequest.cpp 67.69% <0.00%> (-0.97%) ⬇️
...nowhere/knowhere/index/vector_index/IndexAnnoy.cpp 83.54% <0.00%> (-0.21%) ⬇️
core/src/scheduler/task/BuildIndexTask.cpp 92.03% <0.00%> (-0.07%) ⬇️
core/src/server/grpc_impl/GrpcRequestHandler.cpp 85.74% <0.00%> (-0.03%) ⬇️
.../src/server/web_impl/handler/WebRequestHandler.cpp 76.20% <0.00%> (-0.03%) ⬇️
core/src/db/DBImpl.cpp 84.69% <0.00%> (-0.02%) ⬇️
core/unittest/db/test_db_mysql.cpp 99.63% <0.00%> (-0.01%) ⬇️
core/unittest/db/test_db.cpp 99.32% <0.00%> (-0.01%) ⬇️
... and 15 more

@JinHai-CN JinHai-CN merged commit 3b38f7f into milvus-io:0.10.1 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants