Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Insert data validation logic fails to check column type #32769

Open
1 task done
congqixia opened this issue May 6, 2024 · 1 comment
Open
1 task done

[Bug]: Insert data validation logic fails to check column type #32769

congqixia opened this issue May 6, 2024 · 1 comment
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: b904c8d
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Insert data validation logic fails to check column type

Expected Behavior

When insert msg contains wrong data type for any column, proxy shall report error instead of using the field data type to process

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@congqixia congqixia added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 6, 2024
@congqixia congqixia self-assigned this May 6, 2024
congqixia added a commit to congqixia/milvus that referenced this issue May 6, 2024
@congqixia
fix: Validate num of rows for insert field data with schema
7c4adf4 
See also milvus-io#32769

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue May 6, 2024
Merged
This was referenced May 6, 2024
Merged
Merged
Merged
sre-ci-robot pushed a commit that referenced this issue May 6, 2024
@longjiquan
enhance: check field data type of input (#32777)
600db9d 
issue: #32769

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue May 6, 2024
@congqixia
fix: Validate num of rows for insert field data with schema
0b811f6 
See also milvus-io#32769

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
longjiquan added a commit to longjiquan/milvus that referenced this issue May 7, 2024
@longjiquan
enhance: check field data type of input (milvus-io#32777)
31e069f 
issue: milvus-io#32769

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue May 7, 2024
@congqixia
fix: Validate num of rows for insert field data with schema (#32770)
02bf47f 
See also #32769

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue May 7, 2024
@congqixia
fix: Validate num of rows for insert field data with schema (milvus-i…
99b29f9 
…o#32770)

See also milvus-io#32769

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue May 7, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 7, 2024
@longjiquan
enhance: check field data type of input (#32777) (#32789)
2a4a569 
issue: #32769 
pr: #32777

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue May 7, 2024
@longjiquan
enhance: check field data type of input (#32777) (#32790)
2facf61 
issue: #32769 
pr: #32777

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue May 7, 2024
@congqixia
fix: [2.4]Validate num of rows for insert field data with schema (#32770
49b760f 
) (#32799)

Cherry-pick from master 
pr: #32770 
See also #32769

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this issue May 8, 2024
@congqixia
fix: Validate num of rows for insert field data with schema (milvus-i…
80e2d55 
…o#32770)

See also milvus-io#32769

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia mentioned this issue May 8, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 8, 2024
@congqixia
fix: [2.3] Validate num of rows for insert field data with schema (#3…
a631856 
…2770) (#32845)

Cherry-pick from master
pr: #32770 
See also #32769

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@stale Stale
Copy link

stale bot commented Jun 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia