Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: check field data type of input #32777

Merged
merged 1 commit into from
May 6, 2024
Merged

enhance: check field data type of input #32777

merged 1 commit into from
May 6, 2024

Conversation

longjiquan
Copy link
Contributor

issue: #32769

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 6, 2024
@longjiquan longjiquan changed the title enhance: check field data type for int32 & int64 enhance: check field data type of input May 6, 2024
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 6, 2024
@czs007
Copy link
Contributor

czs007 commented May 6, 2024

/approve

@mergify Mergify
Copy link
Contributor

mergify bot commented May 6, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 6, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia
congqixia approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@longjiquan
enhance: check field data type of input
77062c3 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm label May 6, 2024
@czs007
Copy link
Contributor

czs007 commented May 6, 2024

/lgtm

longjiquan added a commit to longjiquan/milvus that referenced this pull request May 6, 2024
@longjiquan
enhance: check field data type of input (milvus-io#32777)
82109e7 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@longjiquan longjiquan mentioned this pull request May 6, 2024
Merged
longjiquan added a commit to longjiquan/milvus that referenced this pull request May 6, 2024
@longjiquan
enhance: check field data type of input (milvus-io#32777)
9b79663 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@longjiquan longjiquan mentioned this pull request May 6, 2024
Merged
@czs007 czs007 added lgtm and removed lgtm labels May 6, 2024
@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 81.76%. Comparing base (6af5275) to head (77062c3).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #32777   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files         998      998           
  Lines      124284   124318   +34     
=======================================
+ Hits       101621   101651   +30     
+ Misses      18800    18795    -5     
- Partials     3863     3872    +9
Files Coverage Δ
internal/proxy/validate_util.go 90.43% <83.33%> (-0.98%) ⬇️

... and 34 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 6, 2024
@sre-ci-robot sre-ci-robot merged commit 600db9d into milvus-io:master May 6, 2024
15 checks passed
@longjiquan longjiquan deleted the fix-validate-util branch May 7, 2024 01:57
longjiquan added a commit to longjiquan/milvus that referenced this pull request May 7, 2024
@longjiquan
enhance: check field data type of input (milvus-io#32777)
31e069f 
issue: milvus-io#32769

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request May 7, 2024
@longjiquan
enhance: check field data type of input (#32777) (#32789)
2a4a569 
issue: #32769 
pr: #32777

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request May 7, 2024
@longjiquan
enhance: check field data type of input (#32777) (#32790)
2facf61 
issue: #32769 
pr: #32777

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@longjiquan @czs007 @sre-ci-robot @congqixia