Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: check field data type of input (#32777) #32790

Merged
merged 2 commits into from
May 7, 2024

Conversation

longjiquan
Copy link
Contributor

issue: #32769
pr: #32777

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 6, 2024
Copy link
Contributor

mergify bot commented May 6, 2024

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 6, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Copy link
Contributor

mergify bot commented May 7, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 7, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 7, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 83.07%. Comparing base (4e82bc4) to head (9f4c2fc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #32790      +/-   ##
==========================================
- Coverage   83.09%   83.07%   -0.03%     
==========================================
  Files         840      850      +10     
  Lines      106359   106557     +198     
==========================================
+ Hits        88383    88524     +141     
- Misses      14677    14723      +46     
- Partials     3299     3310      +11     
Files Coverage Δ
internal/proxy/validate_util.go 91.90% <83.33%> (-1.37%) ⬇️

... and 155 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 7, 2024
@czs007
Copy link
Contributor

czs007 commented May 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2facf61 into milvus-io:2.3 May 7, 2024
14 checks passed
@longjiquan longjiquan deleted the fix-validate-util-23 branch May 7, 2024 07:52
@czs007 czs007 added this to the 2.3.15 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants