-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: multi-col top-k unexpected #33146
Comments
step to reprocess:
|
I did not reproduce the issue on latest milvus 2.4.2 build, I got 50 results as expected. |
@yanliang567 Hi, did you modify the code of mine? is there any error? |
|
milvusdb/milvus:v2.4.0-rc.1 this is the version of mine @yanliang567 |
Is there any change about milvus multi-vector search between these two versions? |
version: '3.5'
services:
etcd:
container_name: milvus-etcd
image: quay.io/coreos/etcd:v3.5.5
environment:
- ETCD_AUTO_COMPACTION_MODE=revision
- ETCD_AUTO_COMPACTION_RETENTION=1000
- ETCD_QUOTA_BACKEND_BYTES=4294967296
- ETCD_SNAPSHOT_COUNT=50000
volumes:
- ${DOCKER_VOLUME_DIRECTORY:-.}/volumes/etcd:/etcd
command: etcd -advertise-client-urls=http://127.0.0.1:2379 -listen-client-urls http://0.0.0.0:2379 --data-dir /etcd
healthcheck:
test: ["CMD", "etcdctl", "endpoint", "health"]
interval: 30s
timeout: 20s
retries: 3
minio:
container_name: milvus-minio
image: minio/minio:RELEASE.2023-03-20T20-16-18Z
environment:
MINIO_ACCESS_KEY: minioadmin
MINIO_SECRET_KEY: minioadmin
ports:
- "9001:9001"
- "9000:9000"
volumes:
- ${DOCKER_VOLUME_DIRECTORY:-.}/volumes/minio:/minio_data
command: minio server /minio_data --console-address ":9001"
healthcheck:
test: ["CMD", "curl", "-f", "http://localhost:9000/minio/health/live"]
interval: 30s
timeout: 20s
retries: 3
standalone:
container_name: milvus-standalone
image: milvusdb/milvus:v2.4.1
command: ["milvus", "run", "standalone"]
security_opt:
- seccomp:unconfined
environment:
ETCD_ENDPOINTS: etcd:2379
MINIO_ADDRESS: minio:9000
volumes:
- ${DOCKER_VOLUME_DIRECTORY:-.}/volumes/milvus:/var/lib/milvus
healthcheck:
test: ["CMD", "curl", "-f", "http://localhost:9091/healthz"]
interval: 30s
start_period: 90s
timeout: 20s
retries: 3
ports:
- "19530:19530"
- "9091:9091"
depends_on:
- "etcd"
- "minio"
networks:
default:
name: milvus This is my docker-compose.yaml file, Is there any problem? before I upgrade milvus from 2.3.5 to 2.4.1, So I run docker compose down
docker compose up -d and I will get warning like below:
I'm not sure whether it will cause this? @yanliang567 |
@JackTan25 |
wget https://raw.githubusercontent.com/milvus-io/milvus/master/scripts/standalone_embed.sh
bash standalone_embed.sh start It seems I can get only 2.4.0, upper version can't be retrieved. |
can we use this script to reproduce on 2.4.2? |
not reproduce on 2.4.2 build, please retry |
well, I can't pull the newest 2.4.2, I can get only 2.4.1 or 2.4.0. And I can reproduce on 2.4.1 and 2.4.0. Can you try these two versions? |
try update the milvus tag to 2.4-20240515-b2d83d33 |
ok, let me check it. |
this is my milvus version: milvusdb/milvus:2.4-20240515-b2d83d33. But I can get just only 10 results. That is very strange. |
Hi, can I see your 50 results distance, I get 0.xxxx distance, that's very strange. ["['id: 115882, distance: 1.0, entity: {}', 'id: 712697, distance: 0.7491630911827087, entity: {}', 'id: 255111, distance: 0.746990442276001, entity: {}', 'id: 735007, distance: 0.7439651489257812, entity: {}', 'id: 425115, distance: 0.7413135766983032, entity: {}', 'id: 81369, distance: 0.7407634258270264, entity: {}', 'id: 714808, distance: 0.7384312152862549, entity: {}', 'id: 464140, distance: 0.7377769947052002, entity: {}', 'id: 93407, distance: 0.733290433883667, entity: {}', 'id: 265376, distance: 0.7315851449966431, entity: {}']"] |
I reinstall milvus like below: ## after download, I modify the tag as 2.4-20240515-b2d83d33context=explore)
wget https://raw.githubusercontent.com/milvus-io/milvus/master/scripts/standalone_embed.sh
bash standalone_embed.sh start |
|
Does milvus will do some change for the l2 distance internally? In fact ,the dataset's l2 distance should not be 0.0xx, the uint8 of every dimension for the column ssnap,bigann. |
I can just get |
did you run on a completed new deployment or on a instance that upgraded from 2.3? |
I do I don't follow the |
that's okay, as long as you can export the logs |
$ docker logs c3b1521e50ea > milvus.log |
What's the problem from the log? |
milvus.log |
I suspect that, I'm in standalone mode and My environment is CentOS7, Intel(R) Xeon(R) CPU E5-2650 |
https://github.com/milvus-io/pymilvus/blob/master/examples/hybrid_search.py We should reference to this file. Let's close this one. |
Is there an existing issue for this?
Environment
Current Behavior
multi-col top-k where k is 50, we can get only ten results.
Expected Behavior
get 50 results.
Steps To Reproduce
No response
Milvus Log
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: