Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add deltaRowCount in l0 compaction #33843

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Jun 13, 2024

See also: #33998
pr: #33997

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 13, 2024
Copy link
Contributor

mergify bot commented Jun 13, 2024

@XuanYang-cn Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Jun 13, 2024
Copy link
Contributor

mergify bot commented Jun 13, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 13, 2024

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jun 14, 2024
Copy link
Contributor

mergify bot commented Jun 14, 2024

@XuanYang-cn Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Jun 14, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (2.4@b3d425f). Learn more about missing BASE report.
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.4   #33843   +/-   ##
======================================
  Coverage       ?   82.25%           
======================================
  Files          ?     1015           
  Lines          ?   129464           
  Branches       ?        0           
======================================
  Hits           ?   106489           
  Misses         ?    18970           
  Partials       ?     4005           
Files Coverage Δ
internal/datacoord/compaction_l0_view.go 91.57% <100.00%> (ø)
internal/datacoord/compaction_view.go 89.41% <100.00%> (ø)
internal/datanode/l0_compactor.go 90.74% <100.00%> (ø)

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Copy link
Contributor

mergify bot commented Jun 19, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot removed the ci-passed label Jun 20, 2024
Copy link
Contributor

mergify bot commented Jun 20, 2024

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

Copy link
Contributor

mergify bot commented Jun 20, 2024

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added the ci-passed label Jun 20, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e55fee6 into milvus-io:2.4 Jun 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants