Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance:[Cherry-Pick] change access log write cache default config #34352

Merged
merged 1 commit into from
Jul 3, 2024
Merged

enhance:[Cherry-Pick] change access log write cache default config #34352

merged 1 commit into from
Jul 3, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Jul 2, 2024 •
edited
Loading

pr: #34354

@aoiasd
fix cache flush interval invalid
0056284 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 2, 2024
@aoiasd aoiasd changed the title enhance: change access log write cache default config enhance:[Cherry-Pick] change access log write cache default config Jul 2, 2024
@mergify mergify bot added the ci-passed label Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.26%. Comparing base (7ee4ccb) to head (0056284).
Report is 13 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #34352       +/-   ##
===========================================
- Coverage   81.46%   70.26%   -11.21%     
===========================================
  Files        1028     1029        +1     
  Lines      132427   132655      +228     
===========================================
- Hits       107879    93205    -14674     
- Misses      20474    35380    +14906     
+ Partials     4074     4070        -4
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.47% <100.00%> (+<0.01%) ⬆️

... and 250 files with indirect coverage changes

@congqixia congqixia added this to the 2.4.6 milestone Jul 3, 2024
@tedxu
Copy link
Collaborator

tedxu commented Jul 3, 2024

/lgtm

congqixia
congqixia approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 18668aa into milvus-io:2.4 Jul 3, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@tedxu tedxu

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
2.4.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aoiasd @tedxu @sre-ci-robot @congqixia