Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Fix go&cpp lint issues #35107

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

congqixia
Copy link
Contributor

See also #34483

@congqixia
Copy link
Contributor Author

/kind branch-feature

@sre-ci-robot sre-ci-robot added approved kind/branch-feature size/M Denotes a PR that changes 30-99 lines. labels Jul 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 30, 2024
See also milvus-io#34483

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added area/compilation area/dependency Pull requests that update a dependency file labels Jul 30, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jul 30, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 30, 2024

/lgtm

Copy link
Contributor

mergify bot commented Jul 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (2.4@d51bfcd). Learn more about missing BASE report.
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.4   #35107   +/-   ##
======================================
  Coverage       ?   80.19%           
======================================
  Files          ?     1051           
  Lines          ?   136716           
  Branches       ?        0           
======================================
  Hits           ?   109643           
  Misses         ?    22881           
  Partials       ?     4192           
Files Coverage Δ
internal/core/src/common/QueryResult.h 97.10% <100.00%> (ø)
internal/core/src/exec/expression/UnaryExpr.cpp 86.44% <100.00%> (ø)
...al/core/src/query/visitors/ExecPlanNodeVisitor.cpp 100.00% <100.00%> (ø)
internal/distributed/proxy/service.go 83.97% <100.00%> (ø)
internal/proxy/accesslog/info/grpc_info.go 96.47% <ø> (ø)
pkg/util/paramtable/component_param.go 98.53% <ø> (ø)
internal/core/src/query/SubSearchResult.h 69.44% <66.66%> (ø)
internal/core/src/storage/DiskFileManagerImpl.cpp 66.73% <0.00%> (ø)

@mergify mergify bot added the ci-passed label Jul 30, 2024
@sre-ci-robot sre-ci-robot merged commit 8991dc2 into milvus-io:2.4 Jul 30, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/branch-feature kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants