fix: missing to support compact for Array type #29505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan, yah01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
need a test on compacting all datatypes |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29505 +/- ##
==========================================
- Coverage 80.84% 80.81% -0.03%
==========================================
Files 917 917
Lines 126902 126917 +15
==========================================
- Hits 102590 102573 -17
- Misses 20995 21021 +26
- Partials 3317 3323 +6
|
|
/hold |
xiaofan-luan
pushed a commit
that referenced
this pull request
Dec 27, 2023
sre-ci-robot
added
size/M
|
rerun ut |
the array type can't be compacted, the system could continue with the inserted segments, but these segments can be never compacted fix milvus-io#29503 Signed-off-by: yah01 <yah2er0ne@outlook.com>
yah01
force-pushed
the
fix-array-compact
branch
from
86ed987
to
de23c16
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the array type can't be compacted, the system could continue with the inserted segments, but these segments can be never compacted
fix #29503