-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing to support compact for Array type (#29505) #29504
Conversation
the array type can't be compacted, the system could continue with the inserted segments, but these segments can be never compacted Signed-off-by: yah01 <yah2er0ne@outlook.com>
@yah01 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan, yah01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #29504 +/- ##
==========================================
- Coverage 82.11% 82.10% -0.01%
==========================================
Files 833 833
Lines 119646 119661 +15
==========================================
+ Hits 98249 98250 +1
- Misses 18168 18184 +16
+ Partials 3229 3227 -2
|
New changes are detected. LGTM label has been removed. |
@yah01 E2e jenkins job failed, comment |
@yah01 ut workflow job failed, comment |
c76f7f5
to
5a8376c
Compare
rerun ut |
the array type can't be compacted, the system could continue with the inserted segments, but these segments can be never compacted
fix #29503
pr: #29505