Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing to support compact for Array type (#29505) #29504

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Dec 26, 2023

the array type can't be compacted, the system could continue with the inserted segments, but these segments can be never compacted

fix #29503
pr: #29505

the array type can't be compacted, the system could continue with the inserted segments, but these segments can be never compacted

Signed-off-by: yah01 <yah2er0ne@outlook.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 26, 2023
Copy link
Contributor

mergify bot commented Dec 26, 2023

@yah01 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/bug Issues or changes related a bug label Dec 26, 2023
@yah01 yah01 changed the title fix: missing to support compact for Array type fix: missing to support compact for Array type (#29505) Dec 26, 2023
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (f5bba79) 82.11% compared to head (1b75080) 82.10%.

❗ Current head 1b75080 differs from pull request most recent head 5a8376c. Consider uploading reports for the commit 5a8376c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #29504      +/-   ##
==========================================
- Coverage   82.11%   82.10%   -0.01%     
==========================================
  Files         833      833              
  Lines      119646   119661      +15     
==========================================
+ Hits        98249    98250       +1     
- Misses      18168    18184      +16     
+ Partials     3229     3227       -2     
Files Coverage Δ
internal/datanode/compactor.go 73.23% <0.00%> (-1.62%) ⬇️

... and 14 files with indirect coverage changes

@sre-ci-robot sre-ci-robot removed the lgtm label Dec 26, 2023
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 26, 2023
Copy link
Contributor

mergify bot commented Dec 26, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: yah01 <yah2er0ne@outlook.com>
@yah01
Copy link
Member Author

yah01 commented Dec 26, 2023

rerun ut

@xiaofan-luan xiaofan-luan merged commit 51cab79 into milvus-io:2.3 Dec 27, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants