Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Compaction can be never done with Array type #29503

Closed
1 task done
yah01 opened this issue Dec 26, 2023 · 3 comments · Fixed by #29505
Closed
1 task done

[Bug]: Compaction can be never done with Array type #29503

yah01 opened this issue Dec 26, 2023 · 3 comments · Fixed by #29505
Assignees
@yah01 @ThreadDao @elstic
Labels
kind/bug Issues or changes related a bug severity/critical Critical, lead to crash, data missing, wrong result, function totally doesn't work. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
2.3.4

Comments

@yah01
Copy link
Member

yah01 commented Dec 26, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 2.3
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

the compactor missing to handle array type, the system could go normally with the original flushed segments, but these segments can be never compacted

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@yah01 yah01 added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 26, 2023
@yah01 yah01 mentioned this issue Dec 26, 2023
Merged
@yah01 yah01 mentioned this issue Dec 26, 2023
Merged
@yah01
Copy link
Member Author

yah01 commented Dec 26, 2023

/assign

@yah01
Copy link
Member Author

yah01 commented Dec 26, 2023

@yanliang567 also we need a e2e testcase to manually compact a collection with array type

xiaofan-luan pushed a commit that referenced this issue Dec 27, 2023
@yah01
fix: missing to support compact for Array type (#29505) (#29504)
51cab79 
the array type can't be compacted, the system could continue with the
inserted segments, but these segments can be never compacted

fix #29503
pr: #29505

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
@yanliang567
Copy link
Contributor

/assign @ThreadDao @elstic
please help to add the array type in compaction e2e and stability nightly.

@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. severity/critical Critical, lead to crash, data missing, wrong result, function totally doesn't work. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 27, 2023
@yanliang567 yanliang567 added this to the 2.3.4 milestone Dec 27, 2023
@yanliang567 yanliang567 removed their assignment Dec 27, 2023
yah01 added a commit to yah01/milvus that referenced this issue Dec 28, 2023
@yah01
fix: missing to support compact for Array type
3f43cc7 
the array type can't be compacted, the system could continue with the inserted segments, but these segments can be never compacted

fix milvus-io#29503

Signed-off-by: yah01 <yah2er0ne@outlook.com>
sre-ci-robot pushed a commit that referenced this issue Dec 28, 2023
@yah01
fix: missing to support compact for Array type (#29505)
a8a0aa9 
the array type can't be compacted, the system could continue with the
inserted segments, but these segments can be never compacted

fix #29503

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yah01 yah01

@ThreadDao ThreadDao

@elstic elstic

Labels
kind/bug Issues or changes related a bug severity/critical Critical, lead to crash, data missing, wrong result, function totally doesn't work. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
2.3.4
Development

Successfully merging a pull request may close this issue.

fix: missing to support compact for Array type yah01/milvus
4 participants
@yah01 @ThreadDao @elstic @yanliang567