Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: erase pk empty check when pk index replace raw data #30432

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: erase pk empty check when pk index replace raw data #30432

merged 1 commit into from
Feb 7, 2024

Conversation

zhagnlu
Copy link
Collaborator

@zhagnlu zhagnlu commented Feb 1, 2024

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 1, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 1, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Collaborator Author

zhagnlu commented Feb 1, 2024

/run-cpu-e2e

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Feb 1, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 1, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Collaborator Author

zhagnlu commented Feb 1, 2024

rerun ut

@xiaofan-luan
Copy link
Contributor

is this a problem for 2.3?

@zhagnlu
Copy link
Collaborator Author

zhagnlu commented Feb 5, 2024

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 5, 2024

@zhagnlu ut workflow job failed, comment rerun ut can trigger the job again.

@zhagnlu
Copy link
Collaborator Author

zhagnlu commented Feb 5, 2024

is this a problem for 2.3?

yes, will cherry-pick to 2,.3

@zhagnlu
Copy link
Collaborator Author

zhagnlu commented Feb 5, 2024

rerun ut

@longjiquan longjiquan mentioned this pull request Feb 5, 2024
Closed
1 task
@zhagnlu zhagnlu force-pushed the fix_pk_empty_assert branch 2 times, most recently from 6b8dc69 to 3f035bf Compare February 5, 2024 09:25
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 5, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

fix: erase pk empty check when load pk index replace raw data
3b8a3d4 
Signed-off-by: luzhang <luzhang@zilliz.com>
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98adbb3) 80.23% compared to head (3b8a3d4) 80.25%.
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30432      +/-   ##
==========================================
+ Coverage   80.23%   80.25%   +0.01%     
==========================================
  Files         965      955      -10     
  Lines      136070   136151      +81     
==========================================
+ Hits       109180   109267      +87     
+ Misses      23171    23163       -8     
- Partials     3719     3721       +2
Files Coverage Δ
internal/core/src/segcore/SegmentSealedImpl.cpp 78.07% <100.00%> (+0.06%) ⬆️
internal/querynodev2/services.go 87.06% <100.00%> (ø)

... and 217 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 6, 2024
@czs007
Copy link
Contributor

czs007 commented Feb 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e8a6f1e into milvus-io:master Feb 7, 2024
14 checks passed
@czs007
Copy link
Contributor

czs007 commented Feb 7, 2024

@zhagnlu please pick to 2.3

zhagnlu added a commit to zhagnlu/milvus that referenced this pull request Feb 7, 2024
@zhagnlu
fix: erase pk empty check when pk index replace raw data (milvus-io#3…
29fdf3e 
…0432)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
@zhagnlu zhagnlu mentioned this pull request Feb 7, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Feb 12, 2024
@zhagnlu
fix: erase pk empty check when pk index replace raw data (#30432) (#3…
a209d05 
…0578)

pr: #30432

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhagnlu @xiaofan-luan @czs007 @sre-ci-robot