Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: erase pk empty check when pk index replace raw data (#30432) #30578

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

zhagnlu
Copy link
Collaborator

@zhagnlu zhagnlu commented Feb 7, 2024

pr: #30432

…0432)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Feb 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be1bd96) 82.05% compared to head (29fdf3e) 82.14%.
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30578      +/-   ##
==========================================
+ Coverage   82.05%   82.14%   +0.09%     
==========================================
  Files         841      831      -10     
  Lines      121958   121267     -691     
==========================================
- Hits       100074    99617     -457     
+ Misses      18643    18404     -239     
- Partials     3241     3246       +5     
Files Coverage Δ
internal/core/src/segcore/SegmentSealedImpl.cpp 78.27% <100.00%> (+0.01%) ⬆️
internal/querynodev2/services.go 88.98% <100.00%> (ø)

... and 125 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 7, 2024
@czs007
Copy link
Contributor

czs007 commented Feb 12, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a209d05 into milvus-io:2.3 Feb 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants