-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Grpcclient return unrecoverable error (#31256) #31452
Conversation
issue: milvus-io#31222 grpcclient's `call` func return a unrecoverable error, then the caller's retry policy also breaks due to this unrecoverable error. This PR introduce `retry.Handle`, the new func use `func() (bool, error)` as input parameters, which return `shouldRetry` directly, to avoid grpcclient return a unrecoverable error Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #31452 +/- ##
=======================================
Coverage 82.22% 82.22%
=======================================
Files 844 844
Lines 122291 122330 +39
=======================================
+ Hits 100549 100584 +35
- Misses 18507 18511 +4
Partials 3235 3235
|
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #31222
pr: #31256
grpcclient's
call
func return a unrecoverable error, then the caller's retry policy also breaks due to this unrecoverable error.This PR introduce
retry.Handle
, the new func usefunc() (bool, error)
as input parameters, which returnshouldRetry
directly, to avoid grpcclient return a unrecoverable error