fix: Grpcclient return unrecoverable error #31256
Conversation
sre-ci-robot
added
size/L
|
@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
weiliu1031
force-pushed
the
fix_retry_not_work
branch
from
508036c
to
667529d
Compare
mergify
bot
added
dco-passed
|
/cc @chyezh |
|
@weiliu1031 E2e jenkins job failed, comment |
|
/lgtm |
|
/run-cpu-e2e |
|
rerun ut |
|
@weiliu1031 E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@weiliu1031 E2e jenkins job failed, comment |
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
weiliu1031
force-pushed
the
fix_retry_not_work
branch
from
667529d
to
27f04be
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31256 +/- ##
==========================================
+ Coverage 80.99% 81.03% +0.03%
==========================================
Files 978 978
Lines 142813 142852 +39
==========================================
+ Hits 115674 115761 +87
+ Misses 23257 23212 -45
+ Partials 3882 3879 -3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: milvus-io#31222 grpcclient's `call` func return a unrecoverable error, then the caller's retry policy also breaks due to this unrecoverable error. This PR introduce `retry.Handle`, the new func use `func() (bool, error)` as input parameters, which return `shouldRetry` directly, to avoid grpcclient return a unrecoverable error Signed-off-by: Wei Liu <wei.liu@zilliz.com>
issue: #31222 pr: #31256 grpcclient's `call` func return a unrecoverable error, then the caller's retry policy also breaks due to this unrecoverable error. This PR introduce `retry.Handle`, the new func use `func() (bool, error)` as input parameters, which return `shouldRetry` directly, to avoid grpcclient return a unrecoverable error Signed-off-by: Wei Liu <wei.liu@zilliz.com>
issue: #31222
grpcclient's
callfunc return a unrecoverable error, then the caller's retry policy also breaks due to this unrecoverable error.This PR introduce
retry.Handle, the new func usefunc() (bool, error)as input parameters, which returnshouldRetrydirectly, to avoid grpcclient return a unrecoverable error