Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: etcd not connectable when auth enabled #31668

Merged
merged 1 commit into from Apr 1, 2024

Conversation

xiaofan-luan
Copy link
Contributor

@xiaofan-luan xiaofan-luan commented Mar 27, 2024

Fix etcd config source didn't respect auth enabled
Also removed pulsar recoverable error when pulsar return ConsumerBusy. It could happen that pulsar didn't find the original consumer is dead and recover takes some time.
fix: #31631
pr: #31633

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 27, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Mar 27, 2024

@xiaofan-luan Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/bug Issues or changes related a bug label Mar 27, 2024
Copy link
Contributor

mergify bot commented Mar 27, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 27, 2024

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 28, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 28, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@xiaofan-luan
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 28, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Contributor Author

/run-cpu-e2e

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.77%. Comparing base (bd6f123) to head (97781a1).
Report is 12 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31668      +/-   ##
==========================================
- Coverage   80.81%   80.77%   -0.04%     
==========================================
  Files         974      974              
  Lines      137886   137890       +4     
==========================================
- Hits       111429   111383      -46     
- Misses      22746    22787      +41     
- Partials     3711     3720       +9     
Files Coverage Δ
pkg/config/etcd_source.go 81.48% <100.00%> (+0.52%) ⬆️
pkg/config/source.go 100.00% <ø> (ø)
pkg/mq/msgstream/mqwrapper/pulsar/pulsar_client.go 80.17% <ø> (+0.51%) ⬆️
pkg/util/etcd/etcd_util.go 77.07% <ø> (ø)
pkg/util/paramtable/base_table.go 80.53% <100.00%> (+0.39%) ⬆️

... and 32 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 29, 2024
@czs007
Copy link
Contributor

czs007 commented Apr 1, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit be83463 into milvus-io:2.4 Apr 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants