-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: etcd not connectable when auth enabled #31668
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xiaofan-luan Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
@xiaofan-luan E2e jenkins job failed, comment |
@xiaofan-luan ut workflow job failed, comment |
0f15824
to
bc67fcf
Compare
@xiaofan-luan E2e jenkins job failed, comment |
bc67fcf
to
fabf51b
Compare
@xiaofan-luan E2e jenkins job failed, comment |
/run-cpu-e2e |
1 similar comment
/run-cpu-e2e |
@xiaofan-luan E2e jenkins job failed, comment |
/run-cpu-e2e |
fabf51b
to
9c23056
Compare
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
9c23056
to
97781a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #31668 +/- ##
==========================================
- Coverage 80.81% 80.77% -0.04%
==========================================
Files 974 974
Lines 137886 137890 +4
==========================================
- Hits 111429 111383 -46
- Misses 22746 22787 +41
- Partials 3711 3720 +9
|
/lgtm |
Fix etcd config source didn't respect auth enabled
Also removed pulsar recoverable error when pulsar return ConsumerBusy. It could happen that pulsar didn't find the original consumer is dead and recover takes some time.
fix: #31631
pr: #31633