Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ExternalETCD - user name is empty error (authentication) #31631

Closed
1 task done
aptmess opened this issue Mar 26, 2024 · 18 comments · Fixed by #31633
Closed
1 task done

[Bug]: ExternalETCD - user name is empty error (authentication) #31631

aptmess opened this issue Mar 26, 2024 · 18 comments · Fixed by #31633
Assignees
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@aptmess
Copy link

aptmess commented Mar 26, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 2.3.12-gpu
- Deployment mode(standalone or cluster): cluster
- MQ type(rocksmq, pulsar or kafka): Kafka
- SDK version(e.g. pymilvus v2.0.0rc2): 2.3.10
- OS(Ubuntu or CentOS): Ubuntu
- CPU/Memory: 40 / 1024
- GPU: 3
- Others:

Current Behavior

Good day!

I am trying to deploy milvus-on-cluster with external components and the latest problem is ETCD. I got the error (the same as in this issue) while milvus is trying to connect:

{"level":"warn",
"ts":"2024-03-26T16:31:03.204Z",
"logger":"etcd-client",
"caller":"v3@v3.5.5/retry_interceptor.go:62",
"msg":"retrying of unary invoker failed",
"target":"etcd-endpoints://<host>:2379",
"attempt":0,
"error":"rpc error: code = InvalidArgument desc = etcdserver: user name is empty"}

I used all configurations in user.yaml - change authorizationEnabled true/false, rbac.enabled true/false:

    common:
      security:
        authorizationEnabled: true
    etcd:
      endpoints:
        - http://<host>:2379
      auth:
        rbac:
          enabled: true
        enable: true
        userName: user
        password: pass

How can I connect to external etcd and solve this problem? Thank you

Expected Behavior

Milvus can connect to External ETCD with authorization.

Steps To Reproduce

Deployment with milvus-on-cluster with `externalEtcd.enabled=true`

Milvus Log

{"level":"warn","ts":"2024-03-26T16:31:03.204Z","logger":"etcd-client","caller":"v3@v3.5.5/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"etcd-endpoints://<host>:2379","attempt":0,"error":"rpc error: code = InvalidArgument desc = etcdserver: user name is empty"}

Anything else?

No response

@aptmess aptmess added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 26, 2024
@xiaofan-luan
Copy link
Collaborator

check the code and seems that the config is correct.

the etcd endpoints is also weird right?
etcd-endpoints://:2379 should it be localhost:2379 or something?

@xiaofan-luan
Copy link
Collaborator

/assign @PowderLi
could you check on this?

I think it might be here

image

@xiaofan-luan
Copy link
Collaborator

I will try to do a quick fix

@xiaofan-luan
Copy link
Collaborator

/assign @xiaofan-luan

@aptmess
Copy link
Author

aptmess commented Mar 27, 2024

Thanks for quick response! I am observing pull request and waiting for merge and new release to test fixes

@yanliang567
Copy link
Contributor

/unassign

@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 27, 2024
@aptmess
Copy link
Author

aptmess commented Apr 1, 2024

Good day! How is quick fix is going ? In which release it would be available (asking cause really need this fix to deploy milvus)? Thanks!

sre-ci-robot pushed a commit that referenced this issue Apr 1, 2024
Fix etcd config source didn't respect auth enabled
Also removed pulsar recoverable error when pulsar return ConsumerBusy.
It could happen that pulsar didn't find the original consumer is dead
and recover takes some time.
fix: #31631
pr: #31633

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Apr 1, 2024
Fix etcd config source didn't respect auth enabled
Also removed pulsar recoverable error when pulsar return ConsumerBusy.
It could happen that pulsar didn't find the original consumer is dead
and recover takes some time.
fix #31631

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
@xiaofan-luan
Copy link
Collaborator

this can be fixed on milvus 2.4

@aptmess
Copy link
Author

aptmess commented Apr 1, 2024

And is there any possible datetime period of 2.4 release in the nearest future?

@xiaofan-luan
Copy link
Collaborator

@aptmess
Actaully I don't think 2.3 support using external username/password

@xiaofan-luan
Copy link
Collaborator

I checked the 2.3 code, there is no that support.
If you'd like maybe you can help on cherry pick this feature back

@aptmess
Copy link
Author

aptmess commented Apr 1, 2024

To clarify - this fix would be able in 2.4?

@aptmess
Copy link
Author

aptmess commented Apr 9, 2024

@xiaofan-luan is there any test docker image which I can try to use to understand that this issue has been solved?

@xiaofan-luan
Copy link
Collaborator

we will release 2.4.0 this week

@aptmess
Copy link
Author

aptmess commented Apr 15, 2024

What about release ?(

@xiaofan-luan
Copy link
Collaborator

@aptmess
what is the current error log you get?

@yanliang567 can we reproduce this in house?

@aptmess
Copy link
Author

aptmess commented Apr 17, 2024

@xiaofan-luan absolutely the same as in the previous one:

{"level":"warn","ts":"2024-03-26T16:31:03.204Z","logger":"etcd-client","caller":"v3@v3.5.5/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"etcd-endpoints://<host>:2379","attempt":0,"error":"rpc error: code = InvalidArgument desc = etcdserver: user name is empty"}

@yanliang567
Copy link
Contributor

lets track this issue in #32365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants