Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [restful]use default search parameter nq: 0 #32355

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix: [restful]use default search parameter nq: 0 #32355

merged 2 commits into from
Apr 18, 2024

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Apr 17, 2024 •
edited

issue: #32225 #31978 #32360

  1. v1 can only accept one vector, but v2 accept list of vectors [Bug]: [restful v2]hybrid search failed when nq is 2 #32225
  2. cannot get dbName from AliasReq [Bug]: [restful v2]The dbName parameter of the describe alias interface did not take effect #31978
  3. enhance: [restful v2]support config DB-Name in the http header [Enhancement]: restful v2, support config dbName in the http header #32360

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 17, 2024
@PowderLi PowderLi mentioned this pull request Apr 17, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi PowderLi mentioned this pull request Apr 17, 2024
Merged
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Apr 17, 2024
@PowderLi
fix: [restful]use default search parameter nq: 0
9c3c6d5 
1. v1 can only accept one vector, but v2 accept list of vectors
2. cannot get dbName from AliasReq

Signed-off-by: PowderLi <min.li@zilliz.com>
@PowderLi
enhance: [restful v2]support config DB-Name in the http header
0597dd6 
Signed-off-by: PowderLi <min.li@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented Apr 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Apr 18, 2024
@PowderLi
fix: [restful]use default search parameter nq: 0 (#32356)
21474c1 
issue: #32225
master pr: #32355

1. v1 can only accept one vector, but v2 accept list of vectors
2. cannot get dbName from AliasReq #31978

---------

Signed-off-by: PowderLi <min.li@zilliz.com>
@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Apr 18, 2024
@sre-ci-robot sre-ci-robot merged commit a0a23d0 into milvus-io:master Apr 18, 2024
12 of 13 checks passed
samhuang-z pushed a commit to samhuang-z/milvus that referenced this pull request Apr 18, 2024
@PowderLi @samhuang-z
fix: [restful]use default search parameter nq: 0 (milvus-io#32356)
988c926 
issue: milvus-io#32225
master pr: milvus-io#32355

1. v1 can only accept one vector, but v2 accept list of vectors
2. cannot get dbName from AliasReq milvus-io#31978

---------

Signed-off-by: PowderLi <min.li@zilliz.com>
czs007 pushed a commit that referenced this pull request Apr 23, 2024
@PowderLi
fix: [restful]use default search parameter nq: 0 (#32362)
2d5f674 
issue: #32225
master pr: #32355 #32485
v2.4 pr: #32356 #32486

1. v1 can only accept one vector, but v2 accept list of vectors
2. cannot get dbName from AliasReq #31978
3. parameters of create collection #31176

---------

Signed-off-by: PowderLi <min.li@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@czs007 czs007 Awaiting requested review from czs007

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PowderLi @czs007 @sre-ci-robot