Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [restful]use default search parameter nq: 0 #32356

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

PowderLi
Copy link
Contributor

issue: #32225
master pr: #32355

  1. v1 can only accept one vector, but v2 accept list of vectors
  2. cannot get dbName from AliasReq [Bug]: [restful v2]The dbName parameter of the describe alias interface did not take effect #31978

1. v1 can only accept one vector, but v2 accept list of vectors
2. cannot get dbName from AliasReq

Signed-off-by: PowderLi <min.li@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 17, 2024
Copy link
Contributor

mergify bot commented Apr 17, 2024

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: PowderLi <min.li@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.60%. Comparing base (82cf91f) to head (72c30ae).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.4   #32356   +/-   ##
=======================================
  Coverage   81.60%   81.60%           
=======================================
  Files         976      976           
  Lines      120017   120017           
=======================================
+ Hits        97940    97943    +3     
+ Misses      18353    18340   -13     
- Partials     3724     3734   +10     
Files Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 89.39% <100.00%> (ø)
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Apr 17, 2024

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 17, 2024
@czs007
Copy link
Contributor

czs007 commented Apr 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 21474c1 into milvus-io:2.4 Apr 18, 2024
15 checks passed
samhuang-z pushed a commit to samhuang-z/milvus that referenced this pull request Apr 18, 2024
issue: milvus-io#32225
master pr: milvus-io#32355

1. v1 can only accept one vector, but v2 accept list of vectors
2. cannot get dbName from AliasReq milvus-io#31978

---------

Signed-off-by: PowderLi <min.li@zilliz.com>
czs007 pushed a commit that referenced this pull request Apr 23, 2024
issue: #32225
master pr: #32355 #32485
v2.4 pr: #32356 #32486

1. v1 can only accept one vector, but v2 accept list of vectors
2. cannot get dbName from AliasReq #31978
3. parameters of create collection #31176

---------

Signed-off-by: PowderLi <min.li@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants