Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [restful v2] parameters of create collection #32485

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: [restful v2] parameters of create collection #32485

merged 1 commit into from
Apr 24, 2024

Conversation

PowderLi
Copy link
Contributor

issue: #31176

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 21, 2024
@PowderLi PowderLi mentioned this pull request Apr 21, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 21, 2024

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Apr 21, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.82%. Comparing base (66fae53) to head (b17ca73).
Report is 30 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32485      +/-   ##
==========================================
+ Coverage   81.76%   81.82%   +0.05%     
==========================================
  Files         999      989      -10     
  Lines      124008   124459     +451     
==========================================
+ Hits       101400   101837     +437     
  Misses      18739    18739              
- Partials     3869     3883      +14
Files Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 89.41% <100.00%> (+0.02%) ⬆️
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <ø> (ø)

... and 241 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 22, 2024
@PowderLi
fix: [restful v2] parameters of create collection
b17ca73 
Signed-off-by: PowderLi <min.li@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Apr 22, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Apr 22, 2024
@czs007
Copy link
Contributor

czs007 commented Apr 23, 2024

/approve
/lgtm

@PowderLi PowderLi mentioned this pull request Apr 23, 2024
Merged
czs007 pushed a commit that referenced this pull request Apr 23, 2024
@PowderLi
fix: [restful]use default search parameter nq: 0 (#32362)
2d5f674 
issue: #32225
master pr: #32355 #32485
v2.4 pr: #32356 #32486

1. v1 can only accept one vector, but v2 accept list of vectors
2. cannot get dbName from AliasReq #31978
3. parameters of create collection #31176

---------

Signed-off-by: PowderLi <min.li@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented Apr 24, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2992282 into milvus-io:master Apr 24, 2024
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Apr 24, 2024
@PowderLi
fix: [restful v2] parameters of create collection (#32486)
7cace01 
issue: #31176
master pr: #32485

Signed-off-by: PowderLi <min.li@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PowderLi @czs007 @sre-ci-robot