Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.3] skip to check auto id when inserting data #32840

Merged
merged 1 commit into from
May 8, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented May 8, 2024

/kind improvement
issue: #32591
pr: #32775
related pr: #32592

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 8, 2024
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 8, 2024
@czs007 czs007 added this to the 2.3.15 milestone May 8, 2024
@czs007
Copy link
Contributor

czs007 commented May 8, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (2facf61) to head (f0189cf).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #32840      +/-   ##
==========================================
- Coverage   83.10%   83.09%   -0.01%     
==========================================
  Files         850      850              
  Lines      106557   106559       +2     
==========================================
- Hits        88555    88549       -6     
- Misses      14704    14709       +5     
- Partials     3298     3301       +3     
Files Coverage Δ
internal/proxy/util.go 91.76% <100.00%> (+0.22%) ⬆️

... and 14 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 8, 2024
@sre-ci-robot sre-ci-robot merged commit f72e89b into milvus-io:2.3 May 8, 2024
16 checks passed
@Yherealtita
Copy link

/kind improvement

issue: #32591

pr: #32775

related pr: #32592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants