fix: query iterator lack results(#33137) #33422
Conversation
sre-ci-robot
added
size/L
mergify
bot
added
dco-passed
|
@MrPresent-Han Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
|
@MrPresent-Han ut workflow job failed, comment |
MrPresent-Han
force-pushed
the
fix-merge-reduce-wrong
branch
from
7115aa4
to
aae7bb4
Compare
|
@MrPresent-Han ut workflow job failed, comment |
MrPresent-Han
force-pushed
the
fix-merge-reduce-wrong
branch
from
aae7bb4
to
06d3b66
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33422 +/- ##
==========================================
+ Coverage 82.16% 82.23% +0.07%
==========================================
Files 1012 1003 -9
Lines 128850 129480 +630
==========================================
+ Hits 105868 106477 +609
- Misses 19007 19023 +16
- Partials 3975 3980 +5
|
| @@ -228,6 +228,7 @@ struct RetrieveResult { | |||
| void* segment_; | |||
| std::vector<int64_t> result_offsets_; | |||
| std::vector<DataArray> field_data_; | |||
| bool has_more_result; | |||
| }; | |||
There was a problem hiding this comment.
actually, this should be 'maybe_has_more_result', when it's true, we cannot discard all possible following results from this source, when it's false, it's definitely ok to ignore results from this source.
| @@ -274,7 +274,7 @@ class OffsetOrderedArray : public OffsetMap { | |||
| hit_num++; | |||
| } | |||
| } | |||
| return seg_offsets; | |||
| return {seg_offsets, it != array_.end()}; | |||
| } | |||
There was a problem hiding this comment.
here, it may not be very accurate because when bitset.count() is 0, it will not move to the end of the array neither. But has_more_result is a 'possible and vague' tag as explained before, so it's ok to simplify here like this
adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
MrPresent-Han
force-pushed
the
fix-merge-reduce-wrong
branch
from
06d3b66
to
b600c4a
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, MrPresent-Han The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
related: milvus-io#33137 adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
pr: milvus-io#33422 issue: milvus-io#33137 Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
…us-io#33422) related: milvus-io#33137 pr: milvus-io#33422 Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
related: milvus-io#33137 adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
related: #33137
adding has_more_result_tag for various level's reduce to rectify reduce_stop_for_best