Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query iterator lack results(#33137) (#33422) #33506

Merged

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented May 31, 2024

related: #33137
pr: #33422

@sre-ci-robot sre-ci-robot added area/internal-api size/L Denotes a PR that changes 100-499 lines. labels May 31, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label May 31, 2024
Copy link
Contributor

mergify bot commented May 31, 2024

@MrPresent-Han Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

Copy link
Contributor

mergify bot commented May 31, 2024

@MrPresent-Han Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (8ff5d27) to head (b6e0ac5).
Report is 18 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33506      +/-   ##
==========================================
+ Coverage   82.15%   82.19%   +0.03%     
==========================================
  Files        1006      997       -9     
  Lines      128421   128637     +216     
==========================================
+ Hits       105510   105732     +222     
+ Misses      18934    18933       -1     
+ Partials     3977     3972       -5     
Files Coverage Δ
internal/core/src/common/QueryResult.h 96.87% <ø> (-1.59%) ⬇️
...al/core/src/query/visitors/ExecPlanNodeVisitor.cpp 97.82% <100.00%> (-0.77%) ⬇️
internal/core/src/segcore/InsertRecord.h 90.98% <100.00%> (+0.14%) ⬆️
internal/core/src/segcore/SegmentGrowingImpl.h 81.03% <ø> (+0.67%) ⬆️
internal/core/src/segcore/SegmentInterface.cpp 88.13% <100.00%> (-0.24%) ⬇️
internal/core/src/segcore/SegmentInterface.h 100.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 80.00% <ø> (ø)
internal/proxy/task_query.go 81.49% <100.00%> (-0.22%) ⬇️
internal/querynodev2/segments/result.go 74.41% <100.00%> (+0.36%) ⬆️
internal/querynodev2/tasks/query_task.go 91.83% <100.00%> (+0.08%) ⬆️
... and 1 more

... and 210 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 627b787 into milvus-io:2.4 Jun 5, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed kind/bug Issues or changes related a bug lgtm needs-dco DCO is missing in this pull request. size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants