-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: query iterator lack results(#33137) (#33422) #33506
fix: query iterator lack results(#33137) (#33422) #33506
Conversation
@MrPresent-Han Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
@MrPresent-Han Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #33506 +/- ##
==========================================
+ Coverage 82.15% 82.19% +0.03%
==========================================
Files 1006 997 -9
Lines 128421 128637 +216
==========================================
+ Hits 105510 105732 +222
+ Misses 18934 18933 -1
+ Partials 3977 3972 -5
|
…us-io#33422) related: milvus-io#33137 pr: milvus-io#33422 Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
1cededd
to
b6e0ac5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, MrPresent-Han The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
related: #33137
pr: #33422