Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lost DroppedAt field when DropCollection #33767

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jun 11, 2024

issue: #33097
pr: #33766

Signed-off-by: chyezh <chyezh@outlook.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 11, 2024
@chyezh
Copy link
Contributor Author

chyezh commented Jun 12, 2024

rerun ut

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (ff9bb17) to head (535a3e8).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.4   #33767   +/-   ##
=======================================
  Coverage   82.22%   82.23%           
=======================================
  Files        1013     1013           
  Lines      129075   129077    +2     
=======================================
+ Hits       106135   106141    +6     
  Misses      18940    18940           
+ Partials     4000     3996    -4     
Files Coverage Δ
internal/datacoord/meta.go 93.47% <100.00%> (+0.01%) ⬆️

... and 25 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 12, 2024
@czs007
Copy link
Contributor

czs007 commented Jun 12, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 74b4bd1 into milvus-io:2.4 Jun 12, 2024
15 checks passed
@chyezh chyezh deleted the fix_unexpected_gc_2_4 branch June 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants