Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lost DroppedAt field when DropCollection #33766

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: lost DroppedAt field when DropCollection #33766

merged 1 commit into from
Jun 12, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jun 11, 2024

issue: #33097

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 11, 2024
@chyezh chyezh mentioned this pull request Jun 11, 2024
Merged
@chyezh
Copy link
Contributor Author

chyezh commented Jun 12, 2024

rerun ut

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Jun 12, 2024

rerun ut

@chyezh
fix: lost DroppedAt field when DropCollection
e54e330 
Signed-off-by: chyezh <chyezh@outlook.com>
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (f7af323) to head (e54e330).
Report is 13 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33766      +/-   ##
==========================================
- Coverage   80.94%   80.90%   -0.05%     
==========================================
  Files        1058     1058              
  Lines      135119   135195      +76     
==========================================
- Hits       109377   109376       -1     
- Misses      21555    21630      +75     
- Partials     4187     4189       +2
Files Coverage Δ
internal/datacoord/meta.go 85.65% <100.00%> (+0.02%) ⬆️

... and 33 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jun 12, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Jun 12, 2024
@chyezh
fix: lost DroppedAt field when DropCollection (#33767)
74b4bd1 
issue: #33097
pr: #33766

Signed-off-by: chyezh <chyezh@outlook.com>
@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jun 12, 2024
@sre-ci-robot sre-ci-robot merged commit b3ee1a4 into milvus-io:master Jun 12, 2024
14 of 15 checks passed
@chyezh chyezh deleted the fix_unexpected_gc branch June 12, 2024 12:29
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@chyezh @yellow-shine
fix: lost DroppedAt field when DropCollection (milvus-io#33766)
1a5308e 
issue: milvus-io#33097

Signed-off-by: chyezh <chyezh@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chyezh @czs007 @sre-ci-robot