Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix data codec writer close #33818

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: fix data codec writer close #33818

merged 1 commit into from
Jun 18, 2024

Conversation

shaoting-huang
Copy link
Contributor

issue:#33813

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 13, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sunby
sunby reviewed Jun 13, 2024
View reviewed changes
internal/storage/data_codec.go Outdated Show resolved Hide resolved
internal/storage/data_codec.go Outdated Show resolved Hide resolved
@sre-ci-robot sre-ci-robot removed the lgtm label Jun 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@shaoting-huang ut workflow job failed, comment rerun ut can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

rerun ut

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@github-actions GitHub Actions
Copy link
Contributor

Hello shaoting-huang, you are not in the organization, so you do not have the permission to rerun the workflow, please contact @milvus-io/milvus-maintainers for help.

@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.94%. Comparing base (e83ecd5) to head (59eb5b6).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33818      +/-   ##
==========================================
- Coverage   80.94%   80.94%   -0.01%     
==========================================
  Files        1050     1058       +8     
  Lines      135805   135562     -243     
==========================================
- Hits       109930   109725     -205     
+ Misses      21688    21674      -14     
+ Partials     4187     4163      -24
Files Coverage Δ
internal/storage/payload_writer.go 91.50% <100.00%> (+1.64%) ⬆️
internal/storage/data_codec.go 75.16% <96.61%> (+5.46%) ⬆️

... and 221 files with indirect coverage changes

@sunby
Copy link
Contributor

sunby commented Jun 14, 2024

/lgtm

@sre-ci-robot sre-ci-robot added lgtm and removed lgtm labels Jun 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 14, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 14, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Jun 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 14, 2024

@shaoting-huang Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jun 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 14, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang shaoting-huang force-pushed the data_codec_cleanup branch 3 times, most recently from 0e5fe3a to 40aede8 Compare June 17, 2024 06:09
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 17, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

rerun ut

@github-actions GitHub Actions
Copy link
Contributor

Hello shaoting-huang, you are not in the organization, so you do not have the permission to rerun the workflow, please contact @milvus-io/milvus-maintainers for help.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@shaoting-huang
fix data codec writer close
59eb5b6 
Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
@mergify mergify bot added the ci-passed label Jun 18, 2024
@sunby
Copy link
Contributor

sunby commented Jun 18, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 8cdc0e6 into milvus-io:master Jun 18, 2024
15 checks passed
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label Jun 26, 2024
@mergify mergify bot removed the ci-passed label Jun 26, 2024
@shaoting-huang shaoting-huang mentioned this pull request Jul 2, 2024
Merged
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@shaoting-huang @yellow-shine
fix: fix data codec writer close (milvus-io#33818)
ce41736 
issue:milvus-io#33813

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
@czs007 czs007 removed the PR | need cherry-pick need cherry pick to other branches label Jul 2, 2024
@mergify mergify bot added the ci-passed label Jul 2, 2024
sre-ci-robot pushed a commit that referenced this pull request Jul 4, 2024
@shaoting-huang
enhance: [cherry-pick] Batch pick PRs related to data codec (#34345)
dd4dfbc 
This PR cherry-picks the following commits related to data codec
- Fix data codec writer close. #33818
- Legacy code clean up. #33838

issue: #33813 #33839 

pr: #33818 #33838

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunby sunby sunby left review comments

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@sunby sunby

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shaoting-huang @xiaofan-luan @sre-ci-robot @sunby @czs007