-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [cherry-pick]Fix datacoord's properties overwriten #34240
Conversation
Signed-off-by: xige-16 <xige2016@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #34240 +/- ##
==========================================
- Coverage 85.61% 81.66% -3.96%
==========================================
Files 761 1015 +254
Lines 107715 130444 +22729
==========================================
+ Hits 92222 106527 +14305
- Misses 11490 19917 +8427
+ Partials 4003 4000 -3
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, xige-16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry-pick from 2.4 pr: milvus-io#33996 milvus-io#33940 milvus-io#34004 milvus-io#34020 milvus-io#34126 milvus-io#34185 milvus-io#34195 milvus-io#34210 milvus-io#34240 Co-authored-by: xige-16 <xige2016@gmail.com> Co-authored-by: yangxuan <xuan.yang@zilliz.com> Co-authored-by: sunby <sunbingyi1992@gmail.com> Co-authored-by: shaoting-huang <shaoting.huang@zilliz.com> Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Cherry-pick from 2.4 pr: #33996 #33940 #34004 #34020 #34126 #34185 #34195 #34210 #34240 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com> Co-authored-by: xige-16 <xige2016@gmail.com> Co-authored-by: yangxuan <xuan.yang@zilliz.com> Co-authored-by: sunby <sunbingyi1992@gmail.com> Co-authored-by: shaoting-huang <shaoting.huang@zilliz.com>
issue: #34144
pr: #34146
/kind bug