Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [hotfix2.4.5] Cherry pick some crucial fixes #34658

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from 2.4
pr: milvus-io#33996 milvus-io#33940 milvus-io#34004 milvus-io#34020 milvus-io#34126 milvus-io#34185 milvus-io#34195 milvus-io#34210 milvus-io#34240

Co-authored-by: xige-16 <xige2016@gmail.com>
Co-authored-by: yangxuan <xuan.yang@zilliz.com>
Co-authored-by: sunby <sunbingyi1992@gmail.com>
Co-authored-by: shaoting-huang <shaoting.huang@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added area/compilation area/dependency Pull requests that update a dependency file labels Jul 12, 2024
@sre-ci-robot sre-ci-robot requested a review from aoiasd July 12, 2024 09:13
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 12, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@czs007 czs007 added this to the 2.4.5-hotfix milestone Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.95%. Comparing base (7f47f0d) to head (26eb16a).
Report is 1 commits behind head on hotfix-2.4.5.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           hotfix-2.4.5   #34658   +/-   ##
=============================================
  Coverage         81.94%   81.95%           
=============================================
  Files              1015     1015           
  Lines            129462   129477   +15     
=============================================
+ Hits             106094   106116   +22     
+ Misses            19363    19357    -6     
+ Partials           4005     4004    -1     
Files Coverage Δ
internal/datacoord/channel_manager_v2.go 85.74% <100.00%> (+0.06%) ⬆️
internal/datanode/importv2/task_import.go 86.50% <100.00%> (+0.32%) ⬆️
internal/datanode/importv2/task_l0_import.go 78.68% <100.00%> (+0.53%) ⬆️
internal/datanode/importv2/task_l0_preimport.go 84.31% <100.00%> (ø)
internal/datanode/importv2/task_preimport.go 91.45% <100.00%> (ø)
internal/kv/tikv/txn_tikv.go 83.56% <100.00%> (ø)
internal/querynodev2/pkoracle/candidate.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/manager.go 78.15% <100.00%> (+0.09%) ⬆️
internal/rootcoord/broker.go 89.74% <100.00%> (ø)
internal/util/initcore/init_core.go 90.47% <100.00%> (+0.37%) ⬆️
... and 1 more

... and 23 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 12, 2024

/lgtm

@czs007 czs007 merged commit 823fba6 into milvus-io:hotfix-2.4.5 Jul 13, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/dependency Pull requests that update a dependency file lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants