Fix URL Compatibility with 2.0.0 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed URL lib altogether (which is opinionated about how URLs should be formed). Stuff like the following should be allowed (as in 2.0.0)
So reverted back to just simple appending of strings to form the final destination url. |
quentinlesceller
approved these changes
Oct 9, 2019
yeastplume
added a commit
to yeastplume/grin-wallet
that referenced
this pull request
Oct 9, 2019
* fix url scheme for consistency with 2.0.0 * rustfmt * remove URL lib and go back to parsing strings for the dest url * rustmft
Merged
yeastplume
added a commit
that referenced
this pull request
Oct 9, 2019
* Fix URL Compatibility with 2.0.0 (#236) * fix url scheme for consistency with 2.0.0 * rustfmt * remove URL lib and go back to parsing strings for the dest url * rustmft * update version number
yyangli
pushed a commit
to mwcproject/mwc-wallet
that referenced
this pull request
May 13, 2020
* fix url scheme for consistency with 2.0.0 * rustfmt * remove URL lib and go back to parsing strings for the dest url * rustmft
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
* fix url scheme for consistency with 2.0.0 * rustfmt * remove URL lib and go back to parsing strings for the dest url * rustmft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unintended consequence of earlier changes to how urls are handled meant that everything but the base URL was being stripped when sending to another wallet. This fix reverts to earlier behaviour, keeping the entire URL+Path intact.
Going to merge into master first, then cherry-pick into the
current/2.1.xbranch