Preallocated Contexts - Take 2 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@GeneFerneau could you throw an eye again on this one? |
Comment on lines
+142
to
+148
| secp256k1_gej d; | ||
| secp256k1_ge a_ge, d_ge, p_ge; | ||
| secp256k1_ge last_ge; | ||
| secp256k1_gej pj; | ||
| secp256k1_fe zi; | ||
| secp256k1_fe zr; | ||
| secp256k1_fe dx_over_dz_squared; |
There was a problem hiding this comment.
This function is also different from the original repo.
https://github.com/bitcoin-core/secp256k1/blob/1e5d50fa93d71d751b95eec6a80f6732879a0071/src/ecmult_impl.h#L145
quentinlesceller
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Looks good to me. Cross checked every line with:
- https://github.com/bitcoin-core/secp256k1
- https://github.com/ElementsProject/secp256k1-zkp
Specifically regarding the differences insecp256k1_ecmult_odd_multiples_table_storage_varcompared with commit at BlockstreamResearch/secp256k1-zkp@efa783f
|
Re-ran tests with ASAN and the fixes from #64, no issues 🚀 Tested against static precomp enabled and disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #61
Slightly more focused, with lower risk