Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #48 #63

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Fix issue #48 #63

merged 1 commit into from
Dec 13, 2020

Conversation

oantolin
Copy link
Contributor

When completing files with consult-completion-in-region, the point in
the minibuffer gets placed initially at the beginning of the last path
component. With this change it starts at the end of minibuffer
contents, as for other types of completion.

When completing files with consult-completion-in-region, the point in
the minibuffer gets placed initially at the beginning of the last path
component. With this change it starts at the end of minibuffer
contents, as for other types of completion.
@minad
Copy link
Owner

minad commented Dec 13, 2020

Maybe add a comment?

@minad minad merged commit 3471514 into minad:master Dec 13, 2020
minad pushed a commit that referenced this pull request Dec 13, 2020
When completing files with consult-completion-in-region, the point in
the minibuffer gets placed initially at the beginning of the last path
component. With this change it starts at the end of minibuffer
contents, as for other types of completion.
@oantolin
Copy link
Contributor Author

Maybe add a comment?

Oh, yes, I should have done that! I'll do it in a little while. I'm a little git ignorant here: do I make a new pull request for that?

@minad
Copy link
Owner

minad commented Dec 13, 2020

I already added a comment. I hope it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants