Add support for updating points with gpuNUFFT #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaithyagr
commented
Jun 21, 2024
chaithyagr
commented
Jun 21, 2024
| cases=CasesTrajectories, | ||
| glob="*random*", | ||
| ) | ||
| @parametrize(backend=["gpunufft"]) |
There was a problem hiding this comment.
@alineyyy you can add finufft and cufinufft here after you add similar support in it. (Remember to also update points for the grad_plan)
6 tasks
paquiteau
requested changes
Jun 24, 2024
|
Adding what we discussed for documenting. We did overcharge the setter as we want to ensure that everything wrt to NUFFT like density compensation update can happen in background when a train function is called. |
paquiteau
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles a part of #132 . Also added tests, which can be extended by @alineyyy to test her use case.
Adding @paquiteau for review. Notice that we need more recent version of gpuNUFFT for it to pass. Tests passing locally for now, but PyPi release is also done, so we can merge ONLY when all tests are green.