MBX-3508: change image scale type #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enotniy
requested changes
Jul 15, 2024
| android:layout_height="wrap_content"> | ||
|
|
||
| <TextView | ||
| android:id="@+id/text_view_title" |
There was a problem hiding this comment.
id этих view совпадают с теми, что в дефотных пушах? Ты проверял?
There was a problem hiding this comment.
почему они должны совпадать? мы ничего не знаем о layout'ах в дефолтных пушах
There was a problem hiding this comment.
ну да, в дефолте вообще называется title, message, icon. Путь будет как будет
sdk/src/main/res/values/dimens.xml
Outdated
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <resources> | |||
| <dimen name="notification_content_margin_end">16dp</dimen> | |||
There was a problem hiding this comment.
давай все наши ресурсы начинать с mindbox
enotniy
reviewed
Jul 15, 2024
sdk/src/main/java/cloud/mindbox/mobile_sdk/pushes/PushNotificationManager.kt
Outdated
Show resolved
Hide resolved
enotniy
reviewed
Jul 15, 2024
| @@ -500,6 +505,7 @@ internal object PushNotificationManager { | |||
| defaultActivity = defaultActivity, | |||
| ) | |||
| .setNotificationStyle( | |||
| context =context, | |||
|
Закрываю, потому что делаем другое решение |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mindbox-cloud/issues-web-mobile/issues/3508