Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] replace header validation test with frgfm 's action #1030

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

felixdittrich92
Copy link
Contributor

This PR:

related to: #957

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1030 (d646053) into main (faf5590) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         135      135           
  Lines        5590     5590           
=======================================
  Hits         5307     5307           
  Misses        283      283           
Flag Coverage Δ
unittests 94.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/cord.py 97.72% <ø> (ø)
doctr/datasets/datasets/base.py 98.00% <ø> (ø)
doctr/datasets/datasets/pytorch.py 100.00% <ø> (ø)
doctr/datasets/datasets/tensorflow.py 100.00% <ø> (ø)
doctr/datasets/detection.py 95.65% <ø> (ø)
doctr/datasets/doc_artefacts.py 93.93% <ø> (ø)
doctr/datasets/funsd.py 97.43% <ø> (ø)
doctr/datasets/generator/base.py 81.08% <ø> (ø)
doctr/datasets/generator/pytorch.py 100.00% <ø> (ø)
doctr/datasets/generator/tensorflow.py 100.00% <ø> (ø)
... and 90 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Aug 25, 2022
@felixdittrich92 felixdittrich92 added the topic: ci Related to CI label Aug 25, 2022
@felixdittrich92 felixdittrich92 marked this pull request as ready for review August 25, 2022 07:04
Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixdittrich92 and @frgfm ! LGTM

@felixdittrich92
Copy link
Contributor Author

Thanks @felixdittrich92 and @frgfm ! LGTM

Thanks goes to @frgfm 🤗

@felixdittrich92 felixdittrich92 merged commit b6e0f52 into mindee:main Aug 25, 2022
@felixdittrich92 felixdittrich92 deleted the update-header-test branch August 25, 2022 08:01
@frgfm
Copy link
Collaborator

frgfm commented Aug 27, 2022

Haha, glad it helped :)

@felixdittrich92 felixdittrich92 mentioned this pull request Sep 26, 2022
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: ci Related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants