[Fix / Misc] Fix conda CI build and publish job and update actions #1453
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1453 +/- ##
=========================================
+ Coverage 0 95.81% +95.81%
=========================================
Files 0 162 +162
Lines 0 7101 +7101
=========================================
+ Hits 0 6804 +6804
- Misses 0 297 +297
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
felixdittrich92
changed the title
.github/workflows/publish.yml
Outdated
| @@ -105,4 +107,4 @@ jobs: | |||
| - name: Install package | |||
| shell: bash -el {0} | |||
| run: | | |||
| conda install -c mindee doctr | |||
| conda install -c mindee -c conda-forge -c pypdfium2-team -c bblanchon doctr | |||
There was a problem hiding this comment.
changed to:
conda config --set channel_priority strict
conda install -c mindee -c pypdfium2-team -c bblanchon -c conda-forge python-doctr
|
Thanks @mara004 your conda section from pypdfium2 was really helpful 👍 |
| @@ -105,4 +107,5 @@ jobs: | |||
| - name: Install package | |||
| shell: bash -el {0} | |||
| run: | | |||
| conda install -c mindee doctr | |||
| conda config --set channel_priority strict | |||
| conda install -c mindee -c pypdfium2-team -c bblanchon -c conda-forge python-doctr | |||
There was a problem hiding this comment.
@frgfm the channel is created automatically the first time it's uploaded correct ? 😅
There was a problem hiding this comment.
Nope, the channel has to be created along with the token so that we can upload it :)
| - uses: conda-incubator/setup-miniconda@v3 | ||
| with: | ||
| auto-update-conda: true | ||
| python-version: 3.8 | ||
| channels: pypdfium2-team,bblanchon,conda-forge |
There was a problem hiding this comment.
The nice thing with putting the channels directly in the command is that it will be the same for installation & we don't rely too much on the evolution of this Github action.
There was a problem hiding this comment.
Mh yeah that's correct but now we have both ways with the action and in publish the same thing without (for installation) :)
| @@ -105,4 +107,5 @@ jobs: | |||
| - name: Install package | |||
| shell: bash -el {0} | |||
| run: | | |||
| conda install -c mindee doctr | |||
| conda config --set channel_priority strict | |||
| conda install -c mindee -c pypdfium2-team -c bblanchon -c conda-forge python-doctr | |||
There was a problem hiding this comment.
Nope, the channel has to be created along with the token so that we can upload it :)
This PR:
Any feedback is welcome :)