Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed CORD dataset and refactored dataset constructors #299

Merged
merged 4 commits into from
Jun 10, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • added bounding box clipping to fix negative coordinates on CORD dataset
  • fixed dataset docstrings
  • refactored dataset constructors

Any feedback is welcome!

@fg-mindee fg-mindee added topic: documentation Improvements or additions to documentation type: enhancement Improvement module: datasets Related to doctr.datasets labels Jun 8, 2021
@fg-mindee fg-mindee added this to the 0.3.0 milestone Jun 8, 2021
@fg-mindee fg-mindee self-assigned this Jun 8, 2021
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #299 (ea704e9) into main (f6b0ff9) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   96.09%   96.04%   -0.06%     
==========================================
  Files          48       48              
  Lines        2124     2122       -2     
==========================================
- Hits         2041     2038       -3     
- Misses         83       84       +1     
Flag Coverage Δ
unittests 96.04% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/funsd.py 96.87% <ø> (ø)
doctr/datasets/recognition.py 90.00% <ø> (ø)
doctr/datasets/sroie.py 94.73% <ø> (ø)
doctr/datasets/cord.py 97.50% <100.00%> (-0.07%) ⬇️
doctr/datasets/detection.py 97.14% <100.00%> (ø)
doctr/datasets/ocr.py 91.89% <100.00%> (-0.22%) ⬇️
...tr/models/detection/differentiable_binarization.py 93.25% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b0ff9...ea704e9. Read the comment docs.

@fg-mindee fg-mindee merged commit a7b1626 into main Jun 10, 2021
@fg-mindee fg-mindee deleted the cord-fix branch June 10, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants