Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added image reading utilities #30

Merged
merged 3 commits into from
Jan 21, 2021
Merged

feat: Added image reading utilities #30

merged 3 commits into from
Jan 21, 2021

Conversation

fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Jan 20, 2021

Following up on #1, this PR introduces the following modifications:

  • implements an image reading function
  • added corresponding unittest
  • added it to the documentation

Successfully merging this PR will close #1

Any feedback is welcome!

@fg-mindee fg-mindee added topic: documentation Improvements or additions to documentation module: io Related to doctr.io ext: tests Related to tests folder labels Jan 20, 2021
@fg-mindee fg-mindee added this to the 0.1.0 milestone Jan 20, 2021
@fg-mindee fg-mindee self-assigned this Jan 20, 2021
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #30 (f046a2e) into main (7a290a4) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   98.85%   98.89%   +0.04%     
==========================================
  Files           9        9              
  Lines         174      181       +7     
==========================================
+ Hits          172      179       +7     
  Misses          2        2              
Impacted Files Coverage Δ
doctr/documents/reader.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a290a4...f046a2e. Read the comment docs.

@fg-mindee fg-mindee merged commit 7387e31 into main Jan 21, 2021
@fg-mindee fg-mindee deleted the read-img branch January 21, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: tests Related to tests folder module: io Related to doctr.io topic: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[documents] Add basic document reader
2 participants