Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRNN Module (implemented with VGG16) #35

Merged
merged 5 commits into from
Jan 22, 2021
Merged

CRNN Module (implemented with VGG16) #35

merged 5 commits into from
Jan 22, 2021

Conversation

charlesmindee
Copy link
Collaborator

This PR implements Abstract RecognitionModel class, with a child : CRNN model implemented with a VGG16.

@charlesmindee charlesmindee added the module: models Related to doctr.models label Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #35 (3b6ce58) into main (90aee92) will decrease coverage by 0.09%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   98.22%   98.12%   -0.10%     
==========================================
  Files          15       17       +2     
  Lines         338      374      +36     
==========================================
+ Hits          332      367      +35     
- Misses          6        7       +1     
Impacted Files Coverage Δ
doctr/models/recognition/model.py 90.00% <90.00%> (ø)
doctr/models/recognition/__init__.py 100.00% <100.00%> (ø)
doctr/models/recognition/crnn.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90aee92...3b6ce58. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a few things to correct, but this looks really good!

doctr/models/recognition/model.py Outdated Show resolved Hide resolved
doctr/models/recognition/crnn.py Outdated Show resolved Hide resolved
doctr/models/recognition/crnn.py Outdated Show resolved Hide resolved
doctr/models/recognition/crnn.py Outdated Show resolved Hide resolved
doctr/models/recognition/crnn.py Outdated Show resolved Hide resolved
doctr/models/recognition/crnn.py Outdated Show resolved Hide resolved
doctr/models/recognition/crnn.py Outdated Show resolved Hide resolved
@fg-mindee fg-mindee added this to the 0.1.0 milestone Jan 22, 2021
@fg-mindee fg-mindee mentioned this pull request Jan 22, 2021
4 tasks
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@charlesmindee charlesmindee merged commit 74f0d79 into main Jan 22, 2021
@charlesmindee charlesmindee deleted the crnn branch January 22, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models Related to doctr.models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants