Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add learning rate scheduler in TF training scripts #360

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Conversation

charlesmindee
Copy link
Collaborator

This PR adds a CosineDecay lr scheduler in both tensorflow training scripts.
Any feedback is welcome!

@charlesmindee charlesmindee self-assigned this Jul 6, 2021
@charlesmindee charlesmindee added type: enhancement Improvement framework: tensorflow Related to TensorFlow backend ext: references Related to references folder labels Jul 6, 2021
@charlesmindee charlesmindee added this to the 0.3.1 milestone Jul 6, 2021
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #360 (9a55806) into main (db1e034) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   96.11%   96.05%   -0.06%     
==========================================
  Files          83       83              
  Lines        3426     3426              
==========================================
- Hits         3293     3291       -2     
- Misses        133      135       +2     
Flag Coverage Δ
unittests 96.05% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/core.py 94.11% <0.00%> (-0.85%) ⬇️
...dels/detection/differentiable_binarization/base.py 91.30% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1e034...9a55806. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this improvement!

@charlesmindee charlesmindee merged commit 2b68c2d into main Jul 6, 2021
@charlesmindee charlesmindee deleted the decay branch July 6, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder framework: tensorflow Related to TensorFlow backend type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants