-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added recognition postprocessor with CTC decoder #37
Conversation
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 97.84% 97.54% -0.30%
==========================================
Files 17 18 +1
Lines 371 408 +37
==========================================
+ Hits 363 398 +35
- Misses 8 10 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I left a few comments, but I'm wondering here: if this is specific to CRNN, then we should put specific parts into the crnn.py file. And I feel like your postprocessing function, could be a class (at init, we can already set num_classes, label_to_dict, ignore_case, ignore_accents, so that the call method only takes logits as inputs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edits! LGTM
Implements CTC decoder with keras backend to decode raw output of CRNN model.
postprocessor input: raw tensor (CRNN output), output: list of words (strings), size = batch_size