-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reco training script with multi paths sets #377
Conversation
Codecov Report
@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 83 83
Lines 3554 3554
=======================================
Hits 3421 3421
Misses 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I'm not sure passing a list to a bash script is a good idea. Say we have dozens of parts, it would be better to assume that all parts are the subfolders of train_set
for instance (train_set/part1
, train_set/part2
, etc.). If the json labels are directly in this folder, then there is only 1 part, if not, we instantiate the set with the first part, then merge the others. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last improvement suggestion and we're good to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR adds the option to train recognition with multiple datasets.
the arg
data_path
in the script is replaced by atrain_data_path
, a list of 1 or more paths andval_data_path
, a path.The structure inside each path must be:
path/images/
andpath/labels.json
.Any feedback is welcome!