Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a draw_boxes function for detection task only #384

Merged
merged 12 commits into from
Aug 3, 2021
Merged

Conversation

charlesmindee
Copy link
Collaborator

This PR adds a draw_boxes function to draw boxes on images when performing detection task.
Partially resolves #89
Any feedback is welcome!

@charlesmindee charlesmindee added type: enhancement Improvement module: utils Related to doctr.utils labels Jul 18, 2021
@charlesmindee charlesmindee added this to the 0.4.0 milestone Jul 18, 2021
@charlesmindee charlesmindee self-assigned this Jul 18, 2021
@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #384 (6633c9a) into main (7f9c305) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
+ Coverage   95.79%   95.84%   +0.04%     
==========================================
  Files          89       89              
  Lines        3690     3702      +12     
==========================================
+ Hits         3535     3548      +13     
+ Misses        155      154       -1     
Flag Coverage Δ
unittests 95.84% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/utils/visualization.py 93.63% <100.00%> (+0.77%) ⬆️
...dels/detection/differentiable_binarization/base.py 91.97% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9c305...6633c9a. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added some comments

doctr/utils/visualization.py Outdated Show resolved Hide resolved
doctr/utils/visualization.py Show resolved Hide resolved
test/common/test_utils_visualization.py Outdated Show resolved Hide resolved
doctr/utils/visualization.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a small thing about an inplace ops

doctr/utils/visualization.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charlesmindee charlesmindee merged commit 7147e12 into main Aug 3, 2021
@charlesmindee charlesmindee deleted the draw branch August 3, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: utils Related to doctr.utils type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[utils] Add visualization capabilities for independent tasks
2 participants