Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed framework alignment on MobileNet V3 implementations #410

Merged
merged 4 commits into from
Aug 12, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • fixed the implementation of mobilenetV3 versions
  • passes the input shape for a proper model build in the unittests of backbones

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement module: models Related to doctr.models framework: tensorflow Related to TensorFlow backend labels Aug 11, 2021
@fg-mindee fg-mindee added this to the 0.3.1 milestone Aug 11, 2021
@fg-mindee fg-mindee self-assigned this Aug 11, 2021
charlesmindee
charlesmindee previously approved these changes Aug 12, 2021
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #410 (466d748) into main (26f2167) will decrease coverage by 0.05%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   95.88%   95.83%   -0.06%     
==========================================
  Files          91       91              
  Lines        3795     3838      +43     
==========================================
+ Hits         3639     3678      +39     
- Misses        156      160       +4     
Flag Coverage Δ
unittests 95.83% <96.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...etection/differentiable_binarization/tensorflow.py 97.47% <ø> (ø)
doctr/models/backbones/mobilenet/tensorflow.py 97.43% <95.91%> (-0.75%) ⬇️
doctr/models/utils/tensorflow.py 100.00% <100.00%> (ø)
doctr/datasets/ocr.py 89.09% <0.00%> (-2.81%) ⬇️
doctr/datasets/datasets/base.py 95.55% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f2167...466d748. Read the comment docs.

@fg-mindee fg-mindee merged commit 86daa0f into main Aug 12, 2021
@fg-mindee fg-mindee deleted the mobilenet branch August 12, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants