feat: Added page visualization function #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 94.73% 92.43% -2.31%
==========================================
Files 23 24 +1
Lines 703 753 +50
==========================================
+ Hits 666 696 +30
- Misses 37 57 +20
Continue to review full report at Codecov.
|
2 tasks
fg-mindee
suggested changes
Feb 2, 2021
There was a problem hiding this comment.
Thanks for the PR! Good design overall, I added some suggestions for user flexibility!
Regarding unittest, could you, without checking the output, at least trying to plot it in the test? (using plt.show(block=False)). It will at least ensure that this gets executed without raising issues
2 tasks
fg-mindee
changed the title
fg-mindee
added
module: utils
fg-mindee
suggested changes
Feb 3, 2021
fg-mindee
suggested changes
Feb 4, 2021
test/test_utils.py
Outdated
| pages = _mock_pages() | ||
| images = [np.ones((300, 200, 3)), np.ones((500, 1000, 3))] | ||
| for image, page in zip(images, pages): | ||
| utils.visualize_page(page, image) |
There was a problem hiding this comment.
utils.visualization.visualize_page(page, image) I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a visualization function of all elements (blocks, artefacts, lines, words) inside a page, with the matplotlib & mplcursors libs.