Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Updated flake8 config to spot unused imports & undefined variables #623

Merged
merged 4 commits into from
Nov 15, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • updates flake8 config to spot unused imports, docstring backslack issues, undefined variables
  • updated codebase to match those constraints

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement topic: ci Related to CI labels Nov 15, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Nov 15, 2021
@fg-mindee fg-mindee self-assigned this Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #623 (9090fc9) into main (400aec0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
+ Coverage   96.16%   96.18%   +0.02%     
==========================================
  Files         111      111              
  Lines        4300     4300              
==========================================
+ Hits         4135     4136       +1     
+ Misses        165      164       -1     
Flag Coverage Δ
unittests 96.18% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/utils/metrics.py 96.59% <ø> (ø)
doctr/datasets/datasets/base.py 95.45% <100.00%> (ø)
...dels/detection/differentiable_binarization/base.py 91.82% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400aec0...9090fc9. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@fg-mindee fg-mindee merged commit 34cae52 into main Nov 15, 2021
@fg-mindee fg-mindee deleted the flake8 branch November 15, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: ci Related to CI type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants