Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 bug canvas dtype for threshold target #645

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

charlesmindee
Copy link
Collaborator

@charlesmindee charlesmindee commented Nov 24, 2021

The threshold target map (of the DB) was set to be an uint8 tensor, but it should contains values between 0 and 1 (which were cast to 0).
This is now fixed.

@charlesmindee charlesmindee self-assigned this Nov 24, 2021
@charlesmindee charlesmindee added type: bug Something isn't working critical High priority module: models Related to doctr.models topic: text detection Related to the task of text detection labels Nov 24, 2021
@charlesmindee charlesmindee modified the milestone: 0.5.0 Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #645 (8d8fa33) into main (95a81a1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
- Coverage   96.06%   96.04%   -0.03%     
==========================================
  Files         112      112              
  Lines        4349     4349              
==========================================
- Hits         4178     4177       -1     
- Misses        171      172       +1     
Flag Coverage Δ
unittests 96.04% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 91.30% <100.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a81a1...8d8fa33. Read the comment docs.

Copy link
Contributor

@fg-mindee fg-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@charlesmindee charlesmindee merged commit f06f42c into main Nov 24, 2021
@charlesmindee charlesmindee deleted the bug_canvas branch November 24, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical High priority module: models Related to doctr.models topic: text detection Related to the task of text detection type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants