Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added LR finder option in PyTorch training scripts #703

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Dec 13, 2021

Following up on #478, this PR adds a LR finder feature in all PyTorch training scripts

Here is how it renders for artefact detection:
lr_find

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement ext: references Related to references folder framework: pytorch Related to PyTorch backend labels Dec 13, 2021
@fg-mindee fg-mindee added this to the 0.5.0 milestone Dec 13, 2021
@fg-mindee fg-mindee self-assigned this Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #703 (533e0a4) into main (d67abd4) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   96.01%   96.14%   +0.12%     
==========================================
  Files         124      124              
  Lines        4648     4648              
==========================================
+ Hits         4463     4469       +6     
+ Misses        185      179       -6     
Flag Coverage Δ
unittests 96.14% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels/detection/differentiable_binarization/base.py 90.55% <0.00%> (+1.11%) ⬆️
doctr/models/detection/linknet/base.py 89.10% <0.00%> (+3.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d67abd4...533e0a4. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit 8af125c into main Dec 13, 2021
@fg-mindee fg-mindee deleted the lr-finder branch December 13, 2021 16:31
@fg-mindee fg-mindee added type: new feature New feature and removed type: enhancement Improvement labels Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder framework: pytorch Related to PyTorch backend type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants