-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add classification module for crop orientation #721
Conversation
Codecov Report
@@ Coverage Diff @@
## main #721 +/- ##
==========================================
- Coverage 96.13% 96.01% -0.13%
==========================================
Files 125 129 +4
Lines 4713 4792 +79
==========================================
+ Hits 4531 4601 +70
- Misses 182 191 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my bad, there is a misunderstanding: either we rename backbone into classification (which would make a lot of sense), or we add your modifications to "backbones", but no need to have both I think!
We can merge both but we still need a predictor + model zoo for classification architectures, and we also need to have a cfg proper to this classification task (because the actual cfg of the mobilenet for instance is for a character classification, it is not the same input size, checkpoints, ...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I suggested a few changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added a few comments, nothing major. Would you mind adding a corresponding section in the documentation please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only missing the documentation 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This PR adds a classification module with a
orientation_classifier
which will be used to classify the orientation of crops (0, 90, 180, 270 degrees ccw).We also provide a
rectify_crops
function in utils which will be used to rotate the crops accordingly.Any feedback is welcome!